----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101360/#review3308 -----------------------------------------------------------
Are you sure the behaviour for the Qt method 100% equivalent to the current? I ask this because now that the deprecated method forwards to it, naturally it's quite important to make sure nothing gets fscked up. kdeui/widgets/klineedit.h <http://git.reviewboard.kde.org/r/101360/#comment2779> Whitespace :p You people and your crappy editors ;-) - Shaun On May 14, 2011, 12:59 a.m., Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101360/ > ----------------------------------------------------------- > > (Updated May 14, 2011, 12:59 a.m.) > > > Review request for kdelibs and Plasma. > > > Summary > ------- > > Since Qt 4.7 QLineEdit::setPlaceholderText is available so > KLineEdit::clickMessage should be deprecated. > I kept clickMessage as not deprecated in plasma/widgets/lineedit but now is > using placeholderText. > > > Diffs > ----- > > kdeui/widgets/klineedit.h 909d1f7 > kdeui/widgets/klineedit.cpp 0dd3690 > plasma/widgets/lineedit.cpp 09c0c66 > > Diff: http://git.reviewboard.kde.org/r/101360/diff > > > Testing > ------- > > > Thanks, > > Davide > >