----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review3579 -----------------------------------------------------------
this patch is a total hack. while the idea of using argb for the translucency is probably good, this patch as it is simply can not go in. - Aaron J. On May 28, 2011, 8:57 p.m., Mathias Stephan Panzenböck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101463/ > ----------------------------------------------------------- > > (Updated May 28, 2011, 8:57 p.m.) > > > Review request for KDE Base Apps. > > > Summary > ------- > > This patch makes dragged folderview icons translucent if composite is > enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D > window, clears any mask on it and sets the Qt::WA_TranslucentBackground > attribute. I use it day to day and it works fine. > > The proper place to fix this would be in Qt, but they wrongfully marked the > bug report as invalid, because they think X11 does not support translucent > windows: > http://bugreports.qt.nokia.com/browse/QTBUG-8519 > > > This addresses bug 256475. > http://bugs.kde.org/show_bug.cgi?id=256475 > > > Diffs > ----- > > plasma/applets/folderview/iconview.h 4d736c5 > plasma/applets/folderview/iconview.cpp 206aff7 > > Diff: http://git.reviewboard.kde.org/r/101463/diff > > > Testing > ------- > > > Thanks, > > Mathias Stephan > >
