-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101498/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
Currently it is impossible to scroll through the popup completion items in
Konqueror's searchbar plugin. The problem stems from the fact that whenever a
user scrolls through the popup completion list, not only does KLineEdit update
its text, and as a result emit the textChanged signal, but it also emits the
textEdited signal. This causes the searchbar plugin which relies on the
textEdited signal to update the matching items from the search engine, to
continually retrieve new matches everytime the user presses the arrow keys to
scroll through the completion items in the popup completion box. This results
in unpredictable behavior since the list is updated while the user is pressing
the scrolling keys.
The attached patch stops KLineEdit from emitting textEdited during scrolling
through the list of completion items.
This addresses bug 256954.
http://bugs.kde.org/show_bug.cgi?id=256954
Diffs
-----
kdeui/widgets/klineedit.cpp 0dd3690
Diff: http://git.reviewboard.kde.org/r/101498/diff
Testing
-------
Thanks,
Dawit
