----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3701 -----------------------------------------------------------
Ship it! Go for it, my friend. - David On May 2, 2011, 9:34 p.m., Nicolas Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101277/ > ----------------------------------------------------------- > > (Updated May 2, 2011, 9:34 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. The first > problem is in kio, where there's two file-static functions with the same name > (isLocalRequest) and slightly different code. > > Fixed by renaming one of the functions. > > > Diffs > ----- > > kio/kio/accessmanagerreply_p.cpp ccc7474799734b91112d70dc81945b8fe9b9f96c > > Diff: http://git.reviewboard.kde.org/r/101277/diff > > > Testing > ------- > > Compilation of kdelibs/kio with and without final. Didn't try installing or > running. > Other parts of kdelibs still don't work with final. > > > Thanks, > > Nicolas > >
