----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101576/#review3892 -----------------------------------------------------------
This review has been submitted with commit d1101e6dae09c73bbf319061fc229da936c4e4bf by Dawit Alemayehu to branch KDE/4.6. - Commit On June 14, 2011, 2:22 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101576/ > ----------------------------------------------------------- > > (Updated June 14, 2011, 2:22 p.m.) > > > Review request for KDE Runtime. > > > Summary > ------- > > The attached patch does the following: > - Removes the regular expression check for IP addresses since QUrl/KUrl > now > correctly parse almost all short url addresses. > - Creates the remaining QRegExp checks once instead of on demand. > - Uses KUser for username name and directory shortcuts, e.g. ~/, > resolution. > - Percent-encodes extra '@' within a URL's username component > (Workaround). > - Adds unit tests for IPv6 URLs and escaping of '@' in usernames. > > > This addresses bugs 69326 and 118413. > http://bugs.kde.org/show_bug.cgi?id=69326 > http://bugs.kde.org/show_bug.cgi?id=118413 > > > Diffs > ----- > > kurifilter-plugins/shorturi/kshorturifilter.h 30bd686 > kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca > kurifilter-plugins/tests/kurifiltertest.cpp f2354d8 > > Diff: http://git.reviewboard.kde.org/r/101576/diff > > > Testing > ------- > > Run the unit test. > > > Thanks, > > Dawit > >
