> On June 19, 2011, 11:15 p.m., Dawit Alemayehu wrote: > > Looks good, but can you also add Q_ASSERT(m_currentView) before the if > > (!m_currentView) checks so that in debug mode this will assert. The view > > should not be null and if it is someone needs to figure out why that is the > > case.
as per our mail conversation: "Well if m_currentView can be NULL, then there is definitely no need to add a Q_ASSERT right ? I was not aware that it could be until you forwarded what David said ; so forget about my comment and handle it as David suggested." I found also now a way to actually make the current view disappear: start konqueror (in my case starts with empty page), select "Settings -> load view profile -> midnight commander" This closes the current view in konqi and opens a new window. Closing active view (Ctrl+Shift+W) crashes konqueror without this patch. I've committed/pushed it now - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101586/#review4036 ----------------------------------------------------------- On June 11, 2011, 6:56 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101586/ > ----------------------------------------------------------- > > (Updated June 11, 2011, 6:56 p.m.) > > > Review request for KDE Base Apps. > > > Summary > ------- > > add some "currentView" 0-pointer checks in konqueror/src/konqmainwindow.cpp > to avoid crashes like #272557 > > > This addresses bug 272557. > http://bugs.kde.org/show_bug.cgi?id=272557 > > > Diffs > ----- > > konqueror/src/konqmainwindow.cpp a309f48 > > Diff: http://git.reviewboard.kde.org/r/101586/diff > > > Testing > ------- > > > Thanks, > > Martin > >
