-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
-----------------------------------------------------------

(Updated June 30, 2011, 10:34 p.m.)


Review request for kdelibs.


Changes
-------

Changed button label to “File Type Options” and moved the button below the type 
label instead of right of it.
New screen shot: http://privat.broulik.de/filedialogpatch2.png


Summary
-------

On IRC this evening somebody found it hard to find the options to edit a 
specific file type. The KCM is a mess unfortunately but I told him that you 
could edit specific file types directly from the properties dialog.
That button is hard to spot, though, which I also often found annoying. It is 
neither labled nor does it stand out as “button”.
This patch solves that issue.

It is in need of discussion whether the label itself should stay but the button 
definitly has to look like a clickable target.

Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot 
is from the initial attempt where i forgot the capitalization :P)


Diffs (updated)
-----

  kio/kfile/kpropertiesdialog.cpp 3382daa 

Diff: http://git.reviewboard.kde.org/r/101800/diff


Testing
-------


Thanks,

Kai Uwe

Reply via email to