> On Feb. 20, 2011, 3:51 p.m., Lukáš Tinkl wrote: > > Looks OK to me > > Lamarque Souza wrote: > Can this patch be commited to trunk?
Ok, I will commit this patch then. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6513/#review9893 ----------------------------------------------------------- On Feb. 21, 2011, 5:29 p.m., alter_schwede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6513/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2011, 5:29 p.m.) > > > Review request for kdelibs and usability. > > > Summary > ------- > > I already posted this patch here: > https://bugs.kde.org/show_bug.cgi?id=265955 > > This is a patch to the kded_randrmonitor service that solves the below > mentioned problem. > If only one output is connected and the user tries to switch the display it > makes sure the connected output gets activated and deactivates all > disconnected > output afterwards. > > Reproducible: Always > > Steps to Reproduce: > 1. Connect an external display to your laptop and use your latop's hotkey > (e.g. > Fn+F6) to active it and deactivate your laptop's display. > 2. Disconnect the external display > 3. Try to switch back to internal display with your keyboard > > Actual Results: > Nothing happens > ---- > I improved my patch. > Now it also automatically deactivates all disconnected outputs on resume from > suspend and switches to a connected monitor if needed. This should fix e.g. > Bug > #257642. > > > This addresses bugs 257642 and 265955. > https://bugs.kde.org/show_bug.cgi?id=257642 > https://bugs.kde.org/show_bug.cgi?id=265955 > > > Diffs > ----- > > /branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h > 1221086 > /branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp > 1221086 > > Diff: http://svn.reviewboard.kde.org/r/6513/diff > > > Testing > ------- > > > Thanks, > > alter_schwede > >