----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102038/#review4952 -----------------------------------------------------------
1) The git diff you have uploaded is cooked 2) As System Settings maintainer, I find this unacceptable as people using KDE applications under other desktops need to access System Settings for the purpose of altering settings shared by KDE applications - and managed through System Settings. Examples: - Colour scheme - Style used - Etc - Ben On July 21, 2011, 10:39 p.m., Jeremy Bicha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102038/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 10:39 p.m.) > > > Review request for KDE Base Apps. > > > Summary > ------- > > Add OnlyShowIn:KDE line to KSysguard & SystemSettings. Otherwise, it's very > frustrating when running any other desktop (Gnome Shell, Unity, etc.) and > seeing multiple apps named the same thing with the same icon without any way > to distinguish them. > > > Diffs > ----- > > ksysguard/gui/ksysguard.desktop 7e8ff32f1e275ee246e79da039509e28e56987cf > systemsettings/app/systemsettings.desktop > 5934a194675cfe152ebdbfd4a9db45ebd48b67a8 > > Diff: http://git.reviewboard.kde.org/r/102038/diff > > > Testing > ------- > > > Thanks, > > Jeremy > >
