----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102231/#review5428 -----------------------------------------------------------
I think the patch is fine, but I need to note two things: 1) I don't really like the addition of a new internalFoo() method in KAboutData. Imho, these should be removed in frameworks 5. But I will accept it as a temporary solution in kdelibs 4 2) DrKonqi also needs a patch to handle that argument... This patch should not be commited before drkonqi has been patched to recognize that argument. - George On Aug. 5, 2011, 11:24 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102231/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2011, 11:24 p.m.) > > > Review request for KDE Runtime, kdelibs, George Kiagiadakis, and Darío Andrés > Rodríguez. > > > Summary > ------- > > Some applications, such as muon and Calligra apps, specify a bugzilla > product/component via the KAboutData::setProductName() call. This works fine > for bug reports via the "Report Bug..." menu, but fails for crashes. These > currently go to "kde/general" when the product is not found. > > This patch adds a "--productname" parameter to the internal DrKonqi > invokation call from the KDE default crash handler, and it is expected that > DrKonqi developers decide if they add this feature in DrKonqi. It should > handle both pure product names (such as "muon"), as well as product/component > combinations (e.g. "muon/installer"). > > > Diffs > ----- > > kdecore/kernel/kaboutdata.h 16861f4 > kdecore/kernel/kaboutdata.cpp e49bddb > kdeui/util/kcrash.cpp b7abece > > Diff: http://git.reviewboard.kde.org/r/102231/diff > > > Testing > ------- > > I forced a crash via Q_ASSERT in a test application, and the "--productname" > parameter got added when it was specified via setProductName(). DrKonqi > failed to handle it, though, it aborted with "drkonqi: Unknown option > 'productname'." > > > Thanks, > > Christoph > >
