> On Aug. 8, 2011, 10:51 p.m., David Jarvie wrote: > > If the proposed patch is unacceptable, I suggest adding a new method > > > > static void allowWindowModal(bool allow); > > > > If called with true, this would enable the behaviour described in the > > apidocs for subsequent KMessageBox instances. By default, or if called with > > false, all KMessageBox instances would behave as now. As I said in an > > earlier comment, being able only to display application modal instances > > just isn't acceptable in some cases.
What about extending the Option enum instead? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5525 ----------------------------------------------------------- On Aug. 7, 2011, 3:18 p.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102246/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2011, 3:18 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > According to the apidocs, KMessageBox instances with a parent widget > specified are supposed to be window modal, not application modal. This patch > fixes this. > > > Diffs > ----- > > kdeui/dialogs/kmessagebox.cpp 939be89 > > Diff: http://git.reviewboard.kde.org/r/102246/diff > > > Testing > ------- > > Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets > in a different window tree were still able to be used. > > kmessageboxtest runs ok. > > > Thanks, > > David > >
