----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101902/#review5559 -----------------------------------------------------------
This review has been submitted with commit d0335a61536c3e9b2dfb710cb43689e9452e488c by Kevin Ottens to branch frameworks. - Commit On July 9, 2011, 3:43 p.m., Kevin Ottens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101902/ > ----------------------------------------------------------- > > (Updated July 9, 2011, 3:43 p.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > This class is meant to get the D-Bus registration logic out of KApplication, > so that it can also be easily provided to QCoreApplication. It also allows to > easily provide the KUniqueApplication behavior, which is tested with the > accompanying unit test. > > Note that it's a somewhat early review request, I'm aware that the APIDOX is > missing for instance. It's just that it'll likely be a generally useful > class, so I'd like to gather feedback early. In short, just in case you were > wondering why it seems unfinished: it is unfinished. :-) > > > Diffs > ----- > > kdecore/CMakeLists.txt 4d96b50 > kdecore/kernel/kdbusservice.h PRE-CREATION > kdecore/kernel/kdbusservice.cpp PRE-CREATION > kdecore/tests/CMakeLists.txt 7c3db77 > kdecore/tests/kdbusservicetest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101902/diff > > > Testing > ------- > > > Thanks, > > Kevin > >
