----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102283/#review5602 -----------------------------------------------------------
IMHO we should not push this before having the support in the KIO slave. As for the branch: it cannot go into 4.7 since it is a feature I suppose. So we need to put it into the new frameworks branch. nepomuk/utils/utils.cpp <http://git.reviewboard.kde.org/r/102283/#comment4997> toString() is sadly not enough. As always we need to use KUrl::url(). - Sebastian On Aug. 10, 2011, 2:15 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102283/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 2:15 p.m.) > > > Review request for kdelibs, Nepomuk and Sebastian Trueg. > > > Summary > ------- > > Add a &resource="nepomuk:/res/some-uuid" in the query url. This allows us to > use the resource uri to set a custom image while displaying results. > > What am I supposed to do with this? Master is frozen. Should I commit to 4.7 > and ? > > > Diffs > ----- > > nepomuk/utils/utils.cpp e81615a > > Diff: http://git.reviewboard.kde.org/r/102283/diff > > > Testing > ------- > > > Thanks, > > Vishesh > >
