----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102288/#review5673 -----------------------------------------------------------
Ship it! Looks good to me, since no one else complained I'd say go ahead and commit. - Thomas On Aug. 10, 2011, 3:50 p.m., Marius Knaust wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102288/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 3:50 p.m.) > > > Review request for kdelibs and Thomas McGuire. > > > Summary > ------- > > I did a fix to the kmail bug 207270 > https://projects.kde.org/projects/kde/kdepim/repository/revisions/569903cef49e4e40b5eac86ec052a07f5d57b231 > and I thought it would be nice to have a consistent behavour throughout all > applications. > With this patch is it possible to close tabs with a middlelick if the tabs > are closeable, otherwise it will emit a mouseMiddleClick signal like befor. > Therefore it shouldn't effect existing implementations. > Also the closed tab won't get the focus while closing, like dolphin did it. > The "compatibility feature for old middle mouse tab moving" is still working. > > > Diffs > ----- > > kdeui/widgets/ktabbar.cpp b9a790b > > Diff: http://git.reviewboard.kde.org/r/102288/diff > > > Testing > ------- > > > Thanks, > > Marius > >
