----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102328/#review5722 -----------------------------------------------------------
Ship it! Thanks for the update, looks good! I've pushed your patch to master and only did a minor adjustment regarding the layout, so that the box is aligned beside the text. - Peter On Aug. 15, 2011, 1:16 p.m., Chirag Anand wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102328/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2011, 1:16 p.m.) > > > Review request for KDE Base Apps and Peter Penz. > > > Summary > ------- > > This patch applies to dolphin/src/views/renamedialog.cpp and > dolphin/src/views/renamedialog.h. It is built on the current master > branch of kde-baseapps repository. > > It replaces the current renaming functionality of Dolphin for multiple > files. The functionality gives user a little more control over how to > rename their files. It asks the user for the starting point of the > sequence of number instead of starting it always from 1. Renaming 3 > files by doing "FILE##.txt" gives us FILE01.txt, FILE02.txt, FILE03.txt. > > If we have to rename these 3 files to FILE04.txt, FILE05.txt, > FILE06.txt, we need 6 files for the operation. We cannot rename files > starting from a random number. Also, we cannot rename file with > different extensions in a sequence. Though this patch does not yet solve > this problem, what it does is to give the user a choice to start the > sequence from wherever he/she wants it to. > > I have used parenthesis '(', ')' instead of '#' as placeholder. For the > above example, we have to rename the files by doing FILE(04).txt and it > will rename the files as required. > > > Diffs > ----- > > dolphin/src/views/renamedialog.h 8d8b73da56c6675b4e81d94f7467e5a52e440c11 > dolphin/src/views/renamedialog.cpp c0c6ad58c1153daed7c15b3f7be661fb39bffb4d > > Diff: http://git.reviewboard.kde.org/r/102328/diff > > > Testing > ------- > > > Thanks, > > Chirag > >
