----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102490/#review6167 -----------------------------------------------------------
Ship it! Thanks, this is a good idea :-) I could not try the patch myself yet but it looks fine. dolphin/src/kitemviews/kitemlistcontainer.cpp <http://git.reviewboard.kde.org/r/102490/#comment5433> Please move the 'if' above the line: KItemList* view = ... As 'view' is not used within the new 'if' - Peter On Aug. 30, 2011, 11:08 a.m., Vishesh Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102490/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2011, 11:08 a.m.) > > > Review request for KDE Base Apps and Peter Penz. > > > Summary > ------- > > Zoom DolphinView when mouse wheel is scrolled with CRTL button pressed. > > > Diffs > ----- > > dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d > dolphin/src/views/dolphinview.h 7c81ea8 > dolphin/src/views/dolphinview.cpp 0991401 > > Diff: http://git.reviewboard.kde.org/r/102490/diff > > > Testing > ------- > > yes > > > Thanks, > > Vishesh > >
