----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102388/#review6699 -----------------------------------------------------------
I did not review the code, so I cannot comment on it. What I am concerned about is how/when this code should be committed. I certainly believe this is 4.8 material, so it should not be committed to kdelibs/4.7, on the other hand, we have no master repo now, so developers/distributions wanting to test this would have to apply it manually, which is unfortunate for such a big feature. - Christoph On Aug. 24, 2011, 4:29 p.m., Cyril Oblikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102388/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2011, 4:29 p.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > Modeless dialog to handle interactions and modifications in CopyJob. > > > Diffs > ----- > > kio/CMakeLists.txt b517621 > kio/kio/copyjob.h eb88c7a > kio/kio/copyjob.cpp eff7825 > kio/kio/interactiondialog/abstractinteractionitem_p.h PRE-CREATION > kio/kio/interactiondialog/abstractinteractionmodel.cpp PRE-CREATION > kio/kio/interactiondialog/abstractinteractionmodel_p.h PRE-CREATION > kio/kio/interactiondialog/allinteractionitem.cpp PRE-CREATION > kio/kio/interactiondialog/allinteractionitem_p.h PRE-CREATION > kio/kio/interactiondialog/allinteractionmodel.cpp PRE-CREATION > kio/kio/interactiondialog/allinteractionmodel_p.h PRE-CREATION > kio/kio/interactiondialog/existinginteractionitem.cpp PRE-CREATION > kio/kio/interactiondialog/existinginteractionitem_p.h PRE-CREATION > kio/kio/interactiondialog/existinginteractionmodel.cpp PRE-CREATION > kio/kio/interactiondialog/existinginteractionmodel_p.h PRE-CREATION > kio/kio/interactiondialog/interactiondialog.h PRE-CREATION > kio/kio/interactiondialog/interactiondialog.cpp PRE-CREATION > kio/kio/interactiondialog/interactiondialogtab.cpp PRE-CREATION > kio/kio/interactiondialog/interactiondialogtab_p.h PRE-CREATION > kio/kio/interactiondialog/renameinteractionwidget.h PRE-CREATION > kio/kio/interactiondialog/renameinteractionwidget.cpp PRE-CREATION > kio/kio/interactiondialog/requestitemmodel.cpp PRE-CREATION > kio/kio/interactiondialog/requestitemmodel_p.h PRE-CREATION > kio/kio/interactiondialog/unreadableinteractionitem.cpp PRE-CREATION > kio/kio/interactiondialog/unreadableinteractionitem_p.h PRE-CREATION > kio/kio/interactiondialog/unreadableinteractionmodel.cpp PRE-CREATION > kio/kio/interactiondialog/unreadableinteractionmodel_p.h PRE-CREATION > kio/kio/jobuidelegate.h 25e0728 > kio/kio/jobuidelegate.cpp 85679c2 > > Diff: http://git.reviewboard.kde.org/r/102388/diff > > > Testing > ------- > > > Thanks, > > Cyril > >
