-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102696/
-----------------------------------------------------------
(Updated Sept. 25, 2011, 4:47 p.m.)
Review request for kdelibs.
Changes
-------
Made cosmetic modification based on feeback from Andreas.
Description
-------
This 5th patch in a serious of patches meant to improve proxy support in KDE
deals with support at the kioslave level. More specifically the http ioslave.
The patch is necessary to provide proper support for PAC script based proxy
configuration. Namely allowing aleternate proxy servers to be specified and
used as necessary. Here are the change this patch makes:
* Add a new function in TCPSlaveBase to connect to the a remote server
without
automatically sending error notitification to the client. [NEW API]
* Move the proxy related code from 'resetSessionSettings' to
'httpOpenConnection'.
Proxy information will now be only set from 'setHost' and reset from
'reparseConfiguration' as it should have been from the beginning. No
need to
reparse proxy related information on every request.
* Added a new variable, proxyUrls, to HTTPRequest to store the multiple
proxy URLs
obtained from the "ProxyUrls" meta-data.
* Modified 'httpShouldCloseConnection' to account for multiple proxy
addresses.
* Modified 'sendQuery' to connect to the remote server before formatting
the HTTP
headers so that the headers can properly reflect the correct proxy
settings.
Diffs (updated)
-----
kio/kio/tcpslavebase.h 3f87ea8
kio/kio/tcpslavebase.cpp ec70559
kioslave/http/http.h d8c47c7
kioslave/http/http.cpp e62c99a
Diff: http://git.reviewboard.kde.org/r/102696/diff/diff
Testing
-------
Thanks,
Dawit Alemayehu
