----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102723/#review6919 -----------------------------------------------------------
Ship it! - Josef Weidendorfer On Sept. 29, 2011, 6:25 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102723/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2011, 6:25 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Using this way to build a for loop: for (const_iterator it=list.constBegin, > end=list.constEnd ; it != end; ++it) > and replacing the count of bits with the QBitArray method for doing that. > callgrind says: > before: 2984 calls to constBegin, 0,00%. 2960531 calls to constEnd, 2.33% > after: 2921 calls to constBegin, 0,00%. 2921 calls to constEnd, 0.00% > > before: calcDiversity, 55.83% (debug enabled) > after: calcDiversity, 14,46% (debug enabled) > > buildsycoca is still not faster than light, but it is only a four lines patch. > > > Diffs > ----- > > kdecore/sycoca/ksycocadict.cpp 17ed9ac > > Diff: http://git.reviewboard.kde.org/r/102723/diff/diff > > > Testing > ------- > > > Thanks, > > Jaime Torres Amate > >
