----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102657/#review6934 -----------------------------------------------------------
The places model is dynamic (as devices can come and go anytime), so you have to connect to the models *changed() signals to get informed of removable devices. Initially, the model is only populated with the static places, so you only get those. Since you need a receiver object, you probably have to make a simple KPlacesMenu subclass. - Christoph Feck On Sept. 22, 2011, 7:30 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102657/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2011, 7:30 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Description > ------- > > The most common usage for "{Copy,Move} To" dolphin context menus is that a > user wants to copy/move a selected file to plugged in USB drive. Show the > mounted removable media also along with "Root Folder" and recently used > entries. > > It would be nice to have "Places" sidebar instead of the current > implementation, which includes Root Folder, Home Folder, Desktop Folder, > other drives including removable media like USB drives etc. See bugs 140475, > 251151 et al. This should also help in scenario where plugged in removable > media is not automatically mounted (which is the default setup at least in > Fedora). I couldn't find a way to easily extend that functionality, though. > > > This addresses bug 251151. > http://bugs.kde.org/show_bug.cgi?id=251151 > > > Diffs > ----- > > lib/konq/konq_copytomenu.cpp ca1d963 > > Diff: http://git.reviewboard.kde.org/r/102657/diff/diff > > > Testing > ------- > > Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user. > > > Screenshots > ----------- > > Places without Devices > http://git.reviewboard.kde.org/r/102657/s/268/ > > > Thanks, > > Rajeesh K Nambiar > >
