> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider, > > is to have a small "Revert/Default" button next to the slider, like what > > the new Locale KCM does. Then we can have both the slider, and a way to use > > the automatic size. > > > > I really would like to see this in 4.8, so if this feature isn't on the > > feature plan yet, please add it, if you need more time for changes. > > > > Fredrik, further comments? > > Lukas Sommer wrote: > Now it's on the feature list. > > About the position: Is it okay whan I move it to below the list? > > About the slider: And how do we distinghish between "resolution dependend > size" and "manual size, choosen be the slider" in the UI? > > The problem is that we don't know the "resolution dependend size". In > xcursors, there is a way to get cursor _pixmaps_ in the default size (that is > what we are doing do display the icon for the entry "resolution dependend" in > the combobox"), but xcursors doesn't provide a way to ask for the cursor size > _value_ directly. > > Furthermore, the question is: What happens when the user changes the > resolution later? The cursor size should adopt automatically - otherwise, > this option would not make sense. But if it adopts automatically, IMHO this > should be reflected an an own state in the UI. > > Lukas Sommer wrote: > About the position: Maybe the screenshot is missleading: Above the size > combobox, there are the buttons "Get new theme" (GHNS), "Install new theme" > and "Remove theme". This is also the reason why the size combobox has such a > big width: It adopts to the width of the buttons above in the grid. > > Christoph Feck wrote: > It was indeed confusing, I had to start the current version to see that > the menu hides the three buttons. Considering that, the position as shown is > probably fine. > > Regarding button next to the slider, I was suggesting a compromise > between Fredrik's suggestion, and our intention to offer a default (DPI > depended) size. I am fine with the combo box, but Fredrik is the module > maintainer :)
@Fredrik Do we need further changes in the design? - Lukas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review6697 ----------------------------------------------------------- On Sept. 2, 2011, 4:40 p.m., Lukas Sommer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101701/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2011, 4:40 p.m.) > > > Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck. > > > Description > ------- > > X11 mouse cursor themes can contain cursors in multiple sizes, making them > pseudo-scalable. > > It is yet possible in KDE to configure manually the mouse cursor size > (editing kcminput.rc). However, the GUI of the corresponding KControl module > didn't provide support to change this. This patch add support for changing > the mouse cursor size to the GUI. > > This are mostly GUI related changes. The underlying data structure > XCursorTheme did yet provide support for choosing different sizes and only > needed some adjustments. > > > This addresses bug 90444. > http://bugs.kde.org/show_bug.cgi?id=90444 > > > Diffs > ----- > > kcontrol/input/xcursor/cursortheme.h 586ccba > kcontrol/input/xcursor/cursortheme.cpp 92abea5 > kcontrol/input/xcursor/legacytheme.h 846bf9b > kcontrol/input/xcursor/previewwidget.h f4d2c4e > kcontrol/input/xcursor/previewwidget.cpp 3c264fc > kcontrol/input/xcursor/themepage.h 38ca893 > kcontrol/input/xcursor/themepage.cpp 6c9f29a > kcontrol/input/xcursor/themepage.ui 2e38054 > kcontrol/input/xcursor/xcursortheme.h b474086 > kcontrol/input/xcursor/xcursortheme.cpp 2ecb9ba > > Diff: http://git.reviewboard.kde.org/r/101701/diff/diff > > > Testing > ------- > > Tested locally. Works fine for me. Also when using non-standard font DPI > values. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/101701/s/248/ > > > Thanks, > > Lukas Sommer > >
