----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103133/#review8535 -----------------------------------------------------------
Unless there are objections before then, I propose to apply this patch on 30th November to meet the 4.7.4 deadline. - David Jarvie On Nov. 14, 2011, 10:58 p.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103133/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2011, 10:58 p.m.) > > > Review request for kdelibs and John Layt. > > > Description > ------- > > After the user enters a date by means of the date picker or by up/down > arrows, the edit field in KDateComboBox shrinks so that it is too small to > display all the characters in the date. In addition, when first displayed, > the widget visibly resizes, which doesn't look particularly good. This patch > fixes these issues. > > Note that the patch is really a workaround for the issue - I haven't managed > to find out exactly why the shrinkage occurs. However, it is a simple fix, so > unless somebody else comes up with a better way, I think it's good enough. > > > Diffs > ----- > > kdeui/widgets/kdatecombobox.cpp fc239bc > > Diff: http://git.reviewboard.kde.org/r/103133/diff/diff > > > Testing > ------- > > Tested successfully in KAlarm's alarm edit dialog. > > > Thanks, > > David Jarvie > >
