> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > > change. > > Jaime Torres Amate wrote: > Could you explain more about the problems you've noticed or fill a bug > report? > Do I have some time to try to fix the problem you've found in KRunner, > instead of reverting the code to a wrong status (as not intended by the > developer) again? > > > Ben Cooksley wrote: > When trying to configure KRunner with this patch applied, CPU usage by > KRunner jumps to about 90% on my system. Checking with gdb shows that quite a > few geometry change events are being generated and widgets are being hidden > and shown again in very quick succession. > > Reverting your patch and recompiling leads KRunner to use 0-1% of the CPU > when browsing the list of plugins in it's configure dialog. > > Unfortunately there is no definitive backtrace for this issue. > I think you do have some time to find a proper fix for the issue, yes. > > You can reproduce by opening KRunner and entering it's configuration > dialog. The whole of KRunner will become very unresponsive and CPU usage > should shoot up to high levels.
100% reproducible. I'll do my best. gdb to the rescue. - Jaime Torres ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8503 ----------------------------------------------------------- On Nov. 17, 2011, 2:37 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103165/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 2:37 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Trivial c++ fixes for some warnings of clang++ (2.99.9999) > memset the structure size, not the pointer size (fortunately, the structure > size is greater than pointer size in this case). > remove double parenthesis > change false to 0 as pointer parameter > use parenthesis to clarify preference between ? and + > > > Diffs > ----- > > kdecore/sycoca/kmemfile.cpp a466bde > kdeui/fonts/kfontchooser.cpp 541f7db > kdeui/tests/ktabwidgettest.cpp fdc3161 > kross/modules/form.cpp 5e260c1 > kutils/kemoticons/kemoticonstheme.cpp c145741 > kutils/kpluginselector.cpp 0a39fcc > > Diff: http://git.reviewboard.kde.org/r/103165/diff/diff > > > Testing > ------- > > Still compiles with g++ > > > Thanks, > > Jaime Torres Amate > >
