----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103348/#review8762 -----------------------------------------------------------
I have an account called shaforo. i could push to kdepimlibs with it, but i couldn't push to kdelibs. is it because of lack of permissions? - Nick Shaforostoff On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103348/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2011, 5:53 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > pretty straightforward and small optimization of kde apps startup time: > avoid calculating luma for the same colors multiple times. > > callgrind shows it is called 4503 times > instead of 12087 at startup of kwrite, which is 1.5%. > > > Diffs > ----- > > kdeui/colors/kcolorutils.cpp efe8cdd > > Diff: http://git.reviewboard.kde.org/r/103348/diff/diff > > > Testing > ------- > > kwrite starts fine with the new kdeui lib > > > Thanks, > > Nick Shaforostoff > >
