> On Dec. 13, 2011, 7:52 p.m., Burkhard Lück wrote:
> > hmm, I tried you patch and e.g running meinproc4/sonnet/index.docbook I get 
> > an HTML file, but no annoying tooltips
> > 
> > But rm -rf build/kdelibs/doc, building kdelibs and then launching 
> > khelpcenter help:/sonnet I still have the tooltips
> >
> 
> T.C. Hollingsworth wrote:
>     kde-include-common.xsl is generated by cmake (because it needs to insert 
> the path to upstream docbook XSLs), so I think you need to rerun cmake to 
> regenerate it.
>     
>     Just did a fresh cmake of kdelibs and 
> build/kdoctools/customization/kde-include-common.xsl looks good.  I'm 
> compiling now to verify.

You are right, using your patch with a clean build of kdelibs I get rid of the 
annoying tooltips.

Ship it, thanks.


- Burkhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103405/#review8935
-----------------------------------------------------------


On Dec. 13, 2011, 7:23 p.m., T.C. Hollingsworth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103405/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 7:23 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> get rid of 'title' attribute in DocBook generated HTML
> fixes annoying tooltips in KDE documentation
> 
> 
> This addresses bug 266664.
>     http://bugs.kde.org/show_bug.cgi?id=266664
> 
> 
> Diffs
> -----
> 
>   kdoctools/customization/kde-include-common.xsl.cmake c7bdd87 
> 
> Diff: http://git.reviewboard.kde.org/r/103405/diff/diff
> 
> 
> Testing
> -------
> 
> ran meinproc4 against several docs
> everything still works fine but no annoying tooltips
> 
> 
> Thanks,
> 
> T.C. Hollingsworth
> 
>

Reply via email to