----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9018 -----------------------------------------------------------
i've made it so that kcmlocale also emit the signal ... now we just need to put the code into the right place, wh ich i imagine is klocale_kde.cpp. it would be nice if KLocale also had a signal for when it changed the time format so that we could know for sure when it was doing with the changes instead of listening to the generic KGlobalSettings signal? plasma/generic/applets/digital-clock/clock.cpp <http://git.reviewboard.kde.org/r/103434/#comment7470> this part belongs in klocale for sure. since this will affect all time keeping bits. the clock will still need to call generatePixmap() and update() though. also, this should be checking what has been changed and only changing on SettingsChanged. (we don't need to do this on, for instance, icon or cursor changes ;) - Aaron J. Seigo On Dec. 16, 2011, 6:35 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103434/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2011, 6:35 p.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > The patch resets time format in digital clock plasmoid when the user changes > the 24h configuration in active-settings. > > The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am > wondering if I should add this change to kdelibs instead of kde-workspace to > avoid duplicating code. Anyway, I wanted someone to review the code to see if > there can be any side effect. > > > This addresses bug 289094. > http://bugs.kde.org/show_bug.cgi?id=289094 > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.h 4aec3fd > plasma/generic/applets/digital-clock/clock.cpp dd03692 > > Diff: http://git.reviewboard.kde.org/r/103434/diff/diff > > > Testing > ------- > > Works in Plasma Active. In Plasma Desktop kcmlocale does not call > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it > does not take effect. Other kcm modules (e.g. keyboard), call emitChange. > > > Thanks, > > Lamarque Vieira Souza > >
