----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103412/#review9026 -----------------------------------------------------------
Ship it! looks good imho, and seems to work without side-effects on disks that aren't full. kio/kio/copyjob.cpp <http://git.reviewboard.kde.org/r/103412/#comment7473> kdelibs style says "braces around all block statements, even single line if/else/for/whiles" :) - Aaron J. Seigo On Dec. 16, 2011, 1:28 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103412/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2011, 1:28 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > this is simple fix for 243160. It gets free space info for the dst partition, > then after each successful file copy it decreases an internally kept > m_freeSpace value. > > this will help us avoid situations when user copies a 4gb long file onto his > disk, then finds out it has not enough space available. > > i hope that i correctly understood kio copy job mechanism and done error > reporting right. > > TODO (from what was asked in the bug): > *checking for single file size limit on vfat. > *if the total size is larger than free space, warn user beforehand immediately > (right now it does the copying until it finds that the next file cannot be > copied completely) > both these require new dialogs with user visible strings and are subject to > be added after 4.8. > > > also as a bonus i changed m_overwriteList to be qset instead of qlist to make > lookup operations faster. > > > This addresses bug 243160. > http://bugs.kde.org/show_bug.cgi?id=243160 > > > Diffs > ----- > > kio/kio/copyjob.cpp eff7825 > > Diff: http://git.reviewboard.kde.org/r/103412/diff/diff > > > Testing > ------- > > files get copied fine. if i copy a bunch of files including one big file > (created with dd if=/dev/zero of=file.out bs=1MB count=300), then the copying > process stops when it gets to this big file (i have small disk on my virtual > machine, only 400 mb free) > > > Thanks, > > Nick Shaforostoff > >
