----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103474/#review9090 -----------------------------------------------------------
Ship it! Ah I see, this code is called when a new favicon is available. Sounds ok then. - David Faure On Dec. 19, 2011, 4:48 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103474/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 4:48 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attach patch removes the artificial restricition that prevents favicons > from being shown for HTML pages that were saved locally and contain the > "shortcut icon" <link> tag. > > > This addresses bug 105602. > http://bugs.kde.org/show_bug.cgi?id=105602 > > > Diffs > ----- > > konqueror/src/konqpixmapprovider.cpp 29f9c15 > > Diff: http://git.reviewboard.kde.org/r/103474/diff/diff > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
