----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103333/#review9226 -----------------------------------------------------------
This seems like a dangerous change to me. With it, you could run multiple instance of "kmail --nofork", and they would step on each other's toes. The whole point of kuniqueapplication (in normal apps, not in konsole), is to prevent multiple instances of the application from running. A developer using --nofork in valgrind or gdb shouldn't run the risk that an app that wasn't mean to run twice, ends up running twice. konsole is doing rather unusual stuff with kuniqueapplication so I can't comment on what would be the proper fix for konsole, but I'm pretty sure it should only affect konsole, not other kuniqueapplications. - David Faure On Dec. 23, 2011, 11:58 a.m., Askar Safin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103333/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2011, 11:58 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > See https://bugs.kde.org/show_bug.cgi?id=288200 > > > This addresses bug 288200. > http://bugs.kde.org/show_bug.cgi?id=288200 > > > Diffs > ----- > > kdeui/kernel/kuniqueapplication.cpp 777fc35 > > Diff: http://git.reviewboard.kde.org/r/103333/diff/diff > > > Testing > ------- > > > Thanks, > > Askar Safin > >
