----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/#review9944 -----------------------------------------------------------
Ship it! kfile/knewfilemenu.cpp <http://git.reviewboard.kde.org/r/103691/#comment8217> Code looks good. But I have to nitpick about one thing: the comment is outdated now. It should rather be something like // If the file will not be detected as a desktop file, due to a known extension (e.g. ".pl"), append ".desktop". #224142. - David Faure On Jan. 18, 2012, 6:26 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103691/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2012, 6:26 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > The attached patch prevents a user generated link file, e.g. link to URL > location, from being identified as something else. For examples, see the bug > reported linked to this review request. > > > This addresses bug 224142. > http://bugs.kde.org/show_bug.cgi?id=224142 > > > Diffs > ----- > > kfile/knewfilemenu.cpp fbb0e48 > > Diff: http://git.reviewboard.kde.org/r/103691/diff/diff > > > Testing > ------- > > Generate a link file to a URL location and see what KDE identifies the file > as. > > > Thanks, > > Dawit Alemayehu > >
