> On Jan. 25, 2012, 12:07 a.m., David Faure wrote: > > konqueror/src/konqtabs.cpp, line 118 > > <http://git.reviewboard.kde.org/r/103740/diff/2/?file=47703#file47703line118> > > > > Shouldn't this connect be removed then? > > > > Isn't there a risk that both signals get emitted in some cases?
Well, that signal is deprecated in KTabWidget and seems to be emitted only if KTabWidget::moveTab is invoked manually. However, that function completely blocks any signal emission before moving tabs. Hence, the issue you mentioned above, which I was also concerned about originally, should not happen. In fact, the mere existence of the aforementioned bug is proof that the movedTab signal is never emitted when a user moves the tab manually. And the reverse is true for the movedTab signal. It is only emitted when KTabWidget::moveTab is called programatically. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10065 ----------------------------------------------------------- On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103740/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2012, 6:18 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > If you open several tabs with different URLs, move one of tabs past the last > tab, and either press enter or reload, the text of the wrong tab is > highlighted eventhough the current active tab is correctly reloaded. The > attached patch fixes the bug of the wrong tab being marked as modified. > > > This addresses bug 266369. > http://bugs.kde.org/show_bug.cgi?id=266369 > > > Diffs > ----- > > konqueror/src/konqtabs.cpp efaaf87 > > Diff: http://git.reviewboard.kde.org/r/103740/diff/diff > > > Testing > ------- > > Follow the testcase steps outlined in the bug report. > > > Thanks, > > Dawit Alemayehu > >
