----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10300 -----------------------------------------------------------
You need a Messages.sh to extract your i18n calls so that they can be translated kioslave/recentdocuments/recentdocuments.cpp <http://git.reviewboard.kde.org/r/103849/#comment8488> That kdelibs4 does not make sense, you need your own translation catalog, loading the kdelibs4 catalog only won't help kioslave/recentdocuments/recentdocuments.protocol <http://git.reviewboard.kde.org/r/103849/#comment8487> Why 4 maxInstances? - Albert Astals Cid On Feb. 2, 2012, 3:23 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103849/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2012, 3:23 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > Add recentdocuments:/ kio slave to kde-runtime. > Did some little rename "recentdocument -> recentdocuments", based on > http://kde-apps.org/content/show.php?content=145878 > > > Diffs > ----- > > kioslave/CMakeLists.txt f3d5b00 > kioslave/recentdocuments/CMakeLists.txt PRE-CREATION > kioslave/recentdocuments/recentdocuments.h PRE-CREATION > kioslave/recentdocuments/recentdocuments.cpp PRE-CREATION > kioslave/recentdocuments/recentdocuments.protocol PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.h PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103849/diff/diff > > > Testing > ------- > > Works for me. > > > Thanks, > > Xuetian Weng > >