----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ -----------------------------------------------------------
(Updated Feb. 21, 2012, 11:55 p.m.) Review request for kdelibs, Ben Cooksley, Eike Hein, Christoph Feck, and Jeremy Paul Whiting. Description ------- https://git.reviewboard.kde.org/r/101486/ broke subclasses of QComboBox that have a USER property like KColorCombo, this patch reverts this change and introduces a different code path to ignore the USER property of QComboBox and KComboBox and make it use our custom code. This addresses bug 293702. http://bugs.kde.org/show_bug.cgi?id=293702 Diffs ----- kdeui/dialogs/kconfigdialogmanager.cpp 18bc44e kdeui/tests/CMakeLists.txt 63788f6 kdeui/tests/kconfigdialog_unittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/103909/diff/ Testing (updated) ------- Ran the attached test, everything worked. Without moving the userproperty = getUserProperty(w); the KColorCombo fails Without adding the propertyIndex stuff the editable KComboBox fails Thanks, Albert Astals Cid
