----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/#review10849 -----------------------------------------------------------
it's +1 for me, but i'll leave the final call to someone that knows better this particular area, also because adding ifdefs is not particularly pretty, so may or may not be an issue - Marco Martin On Feb. 23, 2012, 7:54 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104051/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2012, 7:54 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > If kde-workspace is compiled with mobile profile or for any platform but X11 > then kcminit is not compiled. That is the case for Plasma Active, whre we > compiles kde-workspace with mobile profile. That causes kcmserver wait 10 > seconds everytime it tries to contact kcminit (twice during ksmserver > startup). This patch disables the timeouts in ksmserver if it was compiled > with mobile profile enabled. > > > This addresses bug 294619. > http://bugs.kde.org/show_bug.cgi?id=294619 > > > Diffs > ----- > > ksmserver/startup.cpp e166286 > > Diff: http://git.reviewboard.kde.org/r/104051/diff/ > > > Testing > ------- > > Tested using Plasma Active devel image. > > > Thanks, > > Lamarque Vieira Souza > >
