----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103699/#review11140 -----------------------------------------------------------
Looks ok to me, except for a few details. I presume you tested all combinations? The kuniqueapplication unit test, the new app case, the already-running app case, the --nofork case? kdeui/kernel/kuniqueapplication.cpp <http://git.reviewboard.kde.org/r/103699/#comment8970> Is there a reason for this particular connection name? Seems to match one from Qt itself, can you add a comment about why this is wanted? kdeui/kernel/kuniqueapplication.cpp <http://git.reviewboard.kde.org/r/103699/#comment8972> Qt/kdelibs coding style (for new code) is "no spaces inside parenthesis, opening brace on the same line". kdeui/kernel/kuniqueapplication.cpp <http://git.reviewboard.kde.org/r/103699/#comment8971> Good idea, but please put the app name in a local var at the beginning of the method. It will reduce code duplication (I know it's not much code, but in kde frameworks 5 this will probably not come from KCmdLineArgs anymore). - David Faure On Jan. 15, 2012, 5:28 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103699/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2012, 5:28 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > All KUniqueApplications issue the warning > QDBusConnection: session D-Bus connection created before QCoreApplication. > Application may misbehave. > when runngin with Qt-4.8.0 (qWarning in QDBusDefaultConnection ctor) > > The patch avoids this by temporarily creating a QCoreApplication instance > > > Diffs > ----- > > kdeui/kernel/kuniqueapplication.cpp 777fc35 > > Diff: http://git.reviewboard.kde.org/r/103699/diff/ > > > Testing > ------- > > running kdepasswd > > > Thanks, > > Martin Koller > >