On March 9, 2012, 11:31 a.m., George Kiagiadakis wrote: > > When there are no objections, I suggest to apply this to master to get more > > testing. Crash reporting does not work right now, so there is nothing that > > could break. > > > > If possible, this should also be committed to 4.7 branch later, and > > distributions informed for an eventual online update.
Yes, there is one new string, but it's worth it. We can live with it even untranslated, since it is only shown on error conditions. I intend to apply this both in 4.8 and master at the same time. (i.e. apply to 4.8 and merge 4.8 to master... or is that still not the way to do it?) If there is need for it in 4.7, I'll happily backport it. It should apply just fine actually, I have no reason to believe that it doesn't. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104200/#review11251 ----------------------------------------------------------- On March 9, 2012, 12:45 a.m., George Kiagiadakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104200/ > ----------------------------------------------------------- > > (Updated March 9, 2012, 12:45 a.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This patch partially ports DrKonqi to use xml-rpc, which is done at this > point to support the new bugzilla 4.2 instance on bugs.kde.org. I have tried > to keep the changes as minimal as possible, so that this can be applied to > the 4.8 branch. > > Note that this patch involves copying the kxmlrpcclient library from > kdepimlibs in drkonqi's source code tree. I have done this to avoid modifying > dependencies in 4.8.2. However, if an extra dependency of kde-runtime on > kdepimlibs sounds ok, I can remove the internal copy in master. > > Full history at: > http://quickgit.kde.org/index.php?p=clones%2Fkde-runtime%2Fgkiagia%2Fdrkonqi.git&a=shortlog&h=refs/heads/drkonqi-xmlrpc > > > This addresses bug 295276. > http://bugs.kde.org/show_bug.cgi?id=295276 > > > Diffs > ----- > > drkonqi/CMakeLists.txt 590239dfbd9236463ef11eede699eb84f5806b7a > drkonqi/bugzillalib.h c89c85c8df3724dc6e51ed03aab7ef7362a22472 > drkonqi/bugzillalib.cpp 2df29bd975196b13df02934bfa8899e30d9627f6 > drkonqi/drkonqi_globals.h 9281b0574737632782c96f90dadad1c86abebd0c > drkonqi/kxmlrpc/CMakeLists.txt PRE-CREATION > drkonqi/kxmlrpc/README PRE-CREATION > drkonqi/kxmlrpc/client.h PRE-CREATION > drkonqi/kxmlrpc/client.cpp PRE-CREATION > drkonqi/kxmlrpc/query.h PRE-CREATION > drkonqi/kxmlrpc/query.cpp PRE-CREATION > drkonqi/reportassistantpages_bugzilla.cpp > fba91b6d179c867d9984d2296b7302a469c8d0e5 > > Diff: http://git.reviewboard.kde.org/r/104200/diff/ > > > Testing > ------- > > Sucessfully reported and attached extra backtrace on: > https://bugs4.kde.org/show_bug.cgi?id=294820 > https://bugs4.kde.org/show_bug.cgi?id=294821 > > The duplicate search also seems to be working fine. > > > Thanks, > > George Kiagiadakis > >
