----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/#review11317 -----------------------------------------------------------
Ship it! Ship It! - Jeremy Paul Whiting On March 4, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104149/ > ----------------------------------------------------------- > > (Updated March 4, 2012, 2:58 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > KWidgetItemDelegate does not update when the itemView gets or loses the focus. > This may cause problems with the text colors of the selected indexes. > > I'm not sure if this is the best way to do it, since in all the other places > this is done asyncronously using "QTimer::singleShot(0, this, > SLOT(initializeModel()))", but this initializes the whole model, and I think > it is not needed here. The alternatives are to update the whole model, or to > add another slot to initialize only selected items. > > > Diffs > ----- > > kdeui/itemviews/kwidgetitemdelegate.cpp 828e498 > > Diff: http://git.reviewboard.kde.org/r/104149/diff/ > > > Testing > ------- > > > Thanks, > > Daniele Elmo Domenichelli > >
