----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12066 -----------------------------------------------------------
You're awesome mate :) service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop <http://git.reviewboard.kde.org/r/104428/#comment9497> You need to remove the old stuff from the .desktop file, and fix author and stuff... service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9498> Instead of accessing this via d-bus, you can add (or I can) property with a list of activities to SharedInfo. This way, there will be no problems with slowness. On the other hand, key-stuff registration can be done in a thread or something. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9499> The default shortcuts is something I'd like discussed on the ML. Personally, I'd have them empty by default. - Ivan Čukić On March 31, 2012, 4:19 p.m., makis marimpis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104428/ > ----------------------------------------------------------- > > (Updated March 31, 2012, 4:19 p.m.) > > > Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. > > > Description > ------- > > (follows discarded review: 104391) > > The plugin adds global keyboard shortcuts for changing the activity. > Defaults start from Qt::MetaModifier + Qt::Key_F1. > > Initially, this functionality was implemented (without correct results) using > KActitivities::Controller. > Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds > delay - so it really needs modification/and i would like more guidance > related to dbus :D. > Other than that, feedback is needed. > > > This addresses bugs 265069 and 273467. > http://bugs.kde.org/show_bug.cgi?id=265069 > http://bugs.kde.org/show_bug.cgi?id=273467 > > > Diffs > ----- > > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 > service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION > > service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop > PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION > service/plugins/globalshortcuts/keyboardbindings.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104428/diff/ > > > Testing > ------- > > Logged in. > Used the default shortcuts to switch activities. > It works! > > > Thanks, > > makis marimpis > >