----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104439/#review12073 -----------------------------------------------------------
Could you detail a bit more what was wrong with the way the output is/was being parsed? kdepasswd/kcm/chfnprocess.cpp <http://git.reviewboard.kde.org/r/104439/#comment9517> Unrelated. kdepasswd/kcm/chfnprocess.cpp <http://git.reviewboard.kde.org/r/104439/#comment9518> You're missing a closing ')' here. - Raphael Kubo da Costa On March 29, 2012, 11:45 a.m., Sergey Borovkov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104439/ > ----------------------------------------------------------- > > (Updated March 29, 2012, 11:45 a.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > Very simple patch that fixes Bug 156396. On some systems loop was just going > forever because of the way parsing chfn output was written. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=156396. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=156396 > > > Diffs > ----- > > kdepasswd/kcm/chfnprocess.cpp 9f75d4a > > Diff: http://git.reviewboard.kde.org/r/104439/diff/ > > > Testing > ------- > > Tested it on Mandriva 2011 and Suse 12.2 with KDE 4.8.1 > > > Thanks, > > Sergey Borovkov > >
