----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104479/#review12138 -----------------------------------------------------------
Apart from the formatting this looks good to me. kdeui/widgets/kratingwidget.cpp <http://git.reviewboard.kde.org/r/104479/#comment9568> Please fix the indentation according to kdelibs policy. kdeui/widgets/kratingwidget.cpp <http://git.reviewboard.kde.org/r/104479/#comment9569> Pedantic: please use whitespace correctly. - Sebastian Trueg On April 3, 2012, 5:40 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104479/ > ----------------------------------------------------------- > > (Updated April 3, 2012, 5:40 p.m.) > > > Review request for kdelibs and Sebastian Trueg. > > > Description > ------- > > Patch for bug 171343 (Improving star rating in dolphin) > As suggested here : https://bugs.kde.org/show_bug.cgi?id=171343#c4 > > Now: Clicking once on an empty star= 1 star > Clicking again = 1/2 star > Clicking again = Clears the selected star > > > Diffs > ----- > > kdeui/widgets/kratingwidget.cpp 811ca0a > > Diff: http://git.reviewboard.kde.org/r/104479/diff/ > > > Testing > ------- > > Tested in dolphin > > > Thanks, > > Anant Kamath > >
