----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104529/ -----------------------------------------------------------
Review request for KDE Runtime and Andreas Schneider. Description ------- The following patch address a scenario the following sftp login related patches: https://git.reviewboard.kde.org/r/101332/ https://git.reviewboard.kde.org/r/102428/ missed. Namely, what happens if the user presses cancel not in the original password dialog, but rather in the subsequent retry dialog. This could happen if the user made a typo when entering login and password originally. With this patch all the scenarios work as advertised and kio_sftp behaves almost exactly the same as kio_ftp. Diffs ----- kioslave/sftp/kio_sftp.cpp cfd9bcf Diff: http://git.reviewboard.kde.org/r/104529/diff/ Testing ------- Repeat the testing outlined in https://git.reviewboard.kde.org/r/101332/, but with the following change: In step #1, instead of pressing cancel in the password dialog, enter incorrect login/password. Wait for the the retry dialog to pop up, and then press cancel. Thanks, Dawit Alemayehu
