On Mon, Apr 16, 2012 at 4:41 PM, Raphael Kubo da Costa <[email protected]> wrote: > Aleix Pol <[email protected]> writes: > >> Hi, >> Last friday Pairs [1] was moved from playground/edu to kdereview >> because we want it to be moved to kdeedu. We have been working on it >> for a while already and we would like it to move to kde edu and to be >> included in the next KDE release. >> >> If someone is interested, please take a look into it and tell us what you >> think. > > Could you guys add a license file to the root directory? It'd make > distro people's lives easier. > > I also see that "kdeclarative" is being hardcoded in the > target_link_libraries() call in src/CMakeLists.txt, probably due to [1] > still being reviewed. This may break the build in the unlikely case that > libkdeclarative is not installed in the same directory as the other KDE > libraries or the headers are in a different place (dunno if this has any > impact on Windows or cross-compilation stuff). > > [1] https://git.reviewboard.kde.org/r/104140/
I already added the COPYING file. About the KDeclarative, I agree with this, and I'll wait for this change until it's merged to master to use it. Thanks for the review! Aleix
