----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832/#review12946 -----------------------------------------------------------
MinGW accepts both "__attribute__" and "__declspec" so we maybe could ifdef the platform instead of compiler (consistently with what's being done with KDE_IMPORT / KDE_EXPORT macros) Also on MinGW I see the opposite effect, it only shows the warning when using the attribute (both ways): noret.c: In function 'fatal': noret.c:3: warning: 'noreturn' function does return (tested using mingw-w32, not mingw.org) - Andrius da Costa Ribas On Jan. 31, 2012, 8:58 p.m., Allen Winter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103832/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2012, 8:58 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This diff adds a new macro KDE_NO_RETURN that wraps the noreturn attribute > which is enabled differently based on the compiler. > > > Diffs > ----- > > kdemacros.h.cmake b93242c > > Diff: http://git.reviewboard.kde.org/r/103832/diff/ > > > Testing > ------- > > did a test compile > > > Thanks, > > Allen Winter > >
