----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104630/#review13088 -----------------------------------------------------------
Ship it! Looks OK modulo generic remarks on use of ->toString which will be coming with the big important review. And, of course, the prereqs. kjs/object_object.cpp <http://git.reviewboard.kde.org/r/104630/#comment10209> * consistency kjs/object_object.cpp <http://git.reviewboard.kde.org/r/104630/#comment10210> Why not just pass in jso->prototype to constructor above? - Maks Orlovich On April 16, 2012, 11:03 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104630/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 11:03 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This needs https://git.reviewboard.kde.org/r/104629/ Object.defineProperties > > Strictly implemented to ecma 15.2.3.5 Object.create > > > Diffs > ----- > > kjs/object_object.cpp 986f03f > > Diff: http://git.reviewboard.kde.org/r/104630/diff/ > > > Testing > ------- > > ecmascript & daily surfing > > > Thanks, > > Bernd Buschinski > >
