> On April 29, 2012, 7:56 p.m., Konstantinos Smanis wrote: > > kio/bookmarks/kbookmarkdombuilder.cc, line 41 > > <http://git.reviewboard.kde.org/r/104785/diff/1/?file=59459#file59459line41> > > > > You change the signature here (second argument: bool->QString) > > David Faure wrote: > Wow, well spotted. Dawit, don't you use a script, to normalize > signatures? I thought the Qt developers had one. > > If there's no such script, I'm against making such changes in the future, > it's just too dangerous, for very little gain. If Konstantinos hadn't spotted > this, we would have a nice runtime-only bug now...
I do. The problem here was that running that tool caused a conflict because I had other unrelated changes in two those files. Hence, the mistake is a result of me resolving those issues manually using copy and paste. IOW, it was caused by a human error. I have already fixed those now. Rest assured if I the normalization had to be done by hand, I would have never done it. :) Anyhow, this is the last set of such patches from me. No time for this type of stuff going forward and I hear it is not really necessary in Qt 5 so there is no need to do it. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13105 ----------------------------------------------------------- On April 29, 2012, 8:22 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104785/ > ----------------------------------------------------------- > > (Updated April 29, 2012, 8:22 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The following patch fixes the following krazy2 warnings: > > - Use const references in Q_FOREACH statements where appropriate. > - Normalize yet more signal/slot connections (missing from the first go > round). > - Use brackets instead of double-quotes for the 'config*' header files. > - Fix the #ifdef statements in header files to reflect the header filename. > > I did this a long time ago, but never pushed upstream. As part of my spring > clean up I want to push this local changes upstream. Any objections ? > > > Diffs > ----- > > kio/bookmarks/kbookmarkdialog.cc 713ceff > kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c > kio/bookmarks/kbookmarkimporter.cc 08210f7 > kio/bookmarks/kbookmarkmanager.cc d8a9cb7 > kio/bookmarks/kbookmarkmenu.cc deb973b > kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 > kio/kfile/kfilemetadataprovider.cpp 8caa0c2 > kio/kfile/kfilemetadataprovider_p.h 09d924a > kio/kfile/kfilemetadatareaderprocess.cpp 5103087 > kio/kfile/kimagefilepreview.cpp 74ef8b7 > kio/kio/chmodjob.cpp 85e0c2c > kio/kio/job.h aeaffa2 > kio/kio/job.cpp 5e18998 > kio/kio/jobuidelegate.cpp 85679c2 > kio/kio/kdesktopfileactions.cpp edf2e9c > kio/kio/kfileitemactions.h 27ab4e3 > kio/kio/kfileitemactions.cpp c79a434 > kio/kio/kfilemetainfoitem.cpp 1cab458 > kio/kio/ksambasharedata.cpp aebcb04 > kio/kio/kurifilter.h 289b910 > kio/kio/kurifilter.cpp 0144a2c > kio/kio/renamedialog.cpp 11e55a9 > kio/misc/kpac/proxyscout.cpp 0068ce7 > kio/misc/kpac/script.cpp a595301 > nepomuk/core/resourcedata.cpp d6b0121 > > Diff: http://git.reviewboard.kde.org/r/104785/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
