> On April 30, 2012, 8:41 p.m., David Faure wrote: > > Looks ok, but probably needs rebasing, the code in > > ProtoQueue::removeJob(SimpleJob *job) looks very different here. > > > > (I think checking for job being null is overzealous)
Hmm... It applies just fine here on the 4.8 branch and I do not have any other local changes in scheduler.cpp. No idea what that might. As far as the check for job being NULL might indeed be a bit overzealous, but I was simply following the same thing that was done in the else statement right below that code. Well at least that is my story and I am sticking to it. ;) - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13169 ----------------------------------------------------------- On March 20, 2012, 7:14 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104351/ > ----------------------------------------------------------- > > (Updated March 20, 2012, 7:14 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > This patch sets the top level window that should be used when displaying > message boxes in KIO::SlaveInterface. This is the first step into eliminating > those multiple message boxes that are popped up because of the out-process > design of KIO. Note that this is not the actual resolution, but the first > step. > > > Diffs > ----- > > kio/kio/scheduler.cpp 8d144bb > kio/kio/slaveinterface.h 3cdc2ae > kio/kio/slaveinterface.cpp d2f9f93 > kio/kio/slaveinterface_p.h e2ccfe0 > > Diff: http://git.reviewboard.kde.org/r/104351/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
