----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104662/#review13521 -----------------------------------------------------------
This review has been submitted with commit b546f13eee28428363c74eac49a70f01c2f2bae6 by Maarten De Meyer to branch KDE/4.8. - Commit Hook On April 18, 2012, 4:01 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104662/ > ----------------------------------------------------------- > > (Updated April 18, 2012, 4:01 p.m.) > > > Review request for KDE Runtime and Cornelius Schumacher. > > > Description > ------- > > Fix Bug 152156 - KDE help center does not respect window placement policy > > khelpcenter does not open in the middle of the screen with the kwin centered > window placement policy. > > 1) remove setGeometry on mainwindow > 2) include defaultsize to setupGui (application looked strange when only > using size hinting) > > Any suggestions on a better default? > > > This addresses bug 152156. > http://bugs.kde.org/show_bug.cgi?id=152156 > > > Diffs > ----- > > khelpcenter/mainwindow.cpp dd22425 > > Diff: http://git.reviewboard.kde.org/r/104662/diff/ > > > Testing > ------- > > Compiled, run, changed size, run again, remove configuration, run again > > > Thanks, > > Maarten De Meyer > >