----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104857/#review13777 -----------------------------------------------------------
kjs/string_object.cpp <http://git.reviewboard.kde.org/r/104857/#comment10935> Could you use a const pointer here to make this look less scary? - Maks Orlovich On May 4, 2012, 5:40 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104857/ > ----------------------------------------------------------- > > (Updated May 4, 2012, 5:40 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Implement standard String.trim, also non-standard trimLeft & trimRight > > As trimLeft&trimRight are very similar and easy to implement in trim, and all > modern browser support it as well, I also added it. > > depends on https://git.reviewboard.kde.org/r/104855/ > > > Diffs > ----- > > kjs/string_object.h e890d52 > kjs/string_object.cpp 170e2f7 > > Diff: http://git.reviewboard.kde.org/r/104857/diff/ > > > Testing > ------- > > ecma Strimg.trim tests > > > Thanks, > > Bernd Buschinski > >
