----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104982/#review14135 -----------------------------------------------------------
This review has been submitted with commit 98f63a671d0b8b76d69c7d4b5fc06c5837408672 by Dawit Alemayehu to branch KDE/4.8. - Commit Hook On May 18, 2012, 7:54 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104982/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 7:54 a.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch fixes the issue reported in the aforementioned bug report. > Specifically, it stops Konqueror from restoring the location bar to the > previous URL if > > a.) It was empty as in a newly created tab. > b.) The user typed in a new URL that cannot be handled by Konqueror. The URL > was launched with another application. > > > This addresses bug 270723. > http://bugs.kde.org/show_bug.cgi?id=270723 > > > Diffs > ----- > > konqueror/src/konqview.cpp bfeb20b > > Diff: http://git.reviewboard.kde.org/r/104982/diff/ > > > Testing > ------- > > Tested the following three scenarios: > > 1.) Open a new tab in Konqueror and type-in a URL it cannot handle. > 2.) Open a new tab, browse to any location, and then type-in a URL Konqueror > cannot handle. > 3.) Open a new tab, browse to any location, clear the location bar, and then > type-in a URL Konqueror cannot handle. > > Results with the patch: > 1.) The typed in URL remains in the location bar. > 2.) The previous URL is restored in the location bar. > 3.) Same as #2. > > > Thanks, > > Dawit Alemayehu > >
