----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/#review14178 -----------------------------------------------------------
You forgot to change kjs/tests/ecmatest_broken_* kjs/json_object.cpp <http://git.reviewboard.kde.org/r/105057/#comment11211> Duplicate newline - Rolf Eike Beer On May 25, 2012, 8:19 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105057/ > ----------------------------------------------------------- > > (Updated May 25, 2012, 8:19 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Implement JSON.stringify > > patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse) > > > Diffs > ----- > > kjs/CMakeLists.txt 1188064 > kjs/CommonIdentifiers.h 8ee40e8 > kjs/json_object.h PRE-CREATION > kjs/json_object.cpp PRE-CREATION > kjs/jsonstringify.h PRE-CREATION > kjs/jsonstringify.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105057/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Buschinski > >